Implement the Particle Shifting Technique (PST)#735
Merged
svchb merged 13 commits intotrixi-framework:mainfrom Apr 10, 2025
Merged
Implement the Particle Shifting Technique (PST)#735svchb merged 13 commits intotrixi-framework:mainfrom
svchb merged 13 commits intotrixi-framework:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
==========================================
- Coverage 70.11% 69.38% -0.73%
==========================================
Files 99 100 +1
Lines 6350 6416 +66
==========================================
Hits 4452 4452
- Misses 1898 1964 +66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
efaulhaber
force-pushed
the
particle-shifting
branch
from
9ac3b47 to
ba64d5c
Compare
efaulhaber
changed the title
Member
Author
|
It doesn't really make sense to add a test at this point. I will add a vortex street example later, which will use PST. |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (7)
- src/TrixiParticles.jl: Language not supported
- src/callbacks/callbacks.jl: Language not supported
- src/callbacks/particle_shifting.jl: Language not supported
- src/general/system.jl: Language not supported
- src/schemes/fluid/fluid.jl: Language not supported
- src/visualization/recipes_plots.jl: Language not supported
- src/visualization/write2vtk.jl: Language not supported
LasNikas
requested changes
Apr 9, 2025
LasNikas
approved these changes
Apr 10, 2025
svchb
approved these changes
Apr 10, 2025
Collaborator
|
/run-gpu-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the Particle Shifting Technique by Sun et al. 2017 (10.1016/j.cma.2016.10.028).
Note that the strength of the shifting is directly scaled by the smoothing length.
Low Mach numbers (high speed of sound) stabilize the simulation, but high Mach numbers make the simulation very sensitive to the scaling factor for the shifting.
For Mach 0.2, we get this with the Wendland C2 kernel:
For the Schoenberg Cubic Spline kernel, everything looks alright:
Reducing the shifting by a factor of 2 yields this for the Wendland:
and this for the Cubic Spline Kernel:
So it is evident that our scaling for the Wendland kernels is incorrect and should be changed to be half of the current smoothing length.
Note that this is without shifting:
