Add tooltips to metrics in WebsiteMetricsBar and MetricCard components#3994
Open
Fahleen1 wants to merge 2 commits intoumami-software:masterfrom
Open
Add tooltips to metrics in WebsiteMetricsBar and MetricCard components#3994Fahleen1 wants to merge 2 commits intoumami-software:masterfrom
Fahleen1 wants to merge 2 commits intoumami-software:masterfrom
Conversation
|
@Fahleen1 is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile OverviewGreptile Summaryadded informative tooltips to the five main website metrics (visitors, visits, views, bounce rate, and visit duration) with an info icon next to each metric label Key Changes
Critical Issuethe tooltip strings are hardcoded in English ('Number of unique visitors to your website', 'Total number of sessions on your website', etc.) which breaks internationalization. the rest of the codebase uses Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant WebsiteMetricsBar
participant MetricCard
participant TooltipTrigger
participant Tooltip
User->>WebsiteMetricsBar: views metrics
WebsiteMetricsBar->>WebsiteMetricsBar: fetches data via useWebsiteStatsQuery
WebsiteMetricsBar->>WebsiteMetricsBar: creates metrics array with tooltip strings
loop for each metric
WebsiteMetricsBar->>MetricCard: renders with props (label, value, tooltip)
MetricCard->>MetricCard: displays metric label and value
alt tooltip provided
MetricCard->>TooltipTrigger: wraps info icon
MetricCard->>Tooltip: renders with tooltip text
User->>TooltipTrigger: hovers over info icon
TooltipTrigger->>Tooltip: shows tooltip with description
Tooltip-->>User: displays hardcoded English text
end
end
|
- Added tooltips for unique visitors, total visits, page views, bounce rate, and average visit duration to enhance user understanding of website analytics. - Updated language files for English, Spanish, Persian, Finnish, Faroese, French, Irish, Hebrew, Hindi, Croatian, Hungarian, Indonesian, Italian, Japanese, Khmer, Korean, Lithuanian, Mongolian, Malay, Burmese, Norwegian, Dutch, Polish, Portuguese (Brazil and Portugal), Romanian, Russian, Sinhala, Slovak, Slovenian, Swedish, Tamil, Thai, Turkish, Ukrainian, Urdu, Uzbek, Vietnamese, Chinese (Simplified and Traditional).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3958
Added tooltips in metric content and cards for better accessibility