fix: replace incorrect .qd with .dq in motor commands (deploy_real.py)#88
Open
dcol91863 wants to merge 1 commit intounitreerobotics:mainfrom
Open
fix: replace incorrect .qd with .dq in motor commands (deploy_real.py)#88dcol91863 wants to merge 1 commit intounitreerobotics:mainfrom
dcol91863 wants to merge 1 commit intounitreerobotics:mainfrom
Conversation
The MotorCmd field for desired velocity is named 'dq', not 'qd'. Using 'qd' silently sets an unrelated (or non-existent) attribute, meaning the desired joint velocity is never actually zeroed out. Fixes unitreerobotics#61
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #61
The
MotorCmdstruct field for desired joint velocity is nameddq, notqd. All five occurrences indeploy_real.pywere using the wrong field name:Affected lines
move_to_default_pos()— leg joints interpolation loopdefault_pos_state()— leg joints hold loopdefault_pos_state()— arm/waist joints hold looprun()— leg joints command buildrun()— arm/waist joints command buildImpact
Using
.qdsilently assigns to a non-existent (or unintended) attribute on theMotorCmdobject, so the desired joint velocity is never actually zeroed out during deployment. This can cause unexpected motor behavior on real hardware.Test plan
MotorCmdfield name againstunitree_sdk2_pythonIDL definition (dqis correct)