fix compile dependencies bug#10
Merged
Agnel-Wang merged 1 commit intounitreerobotics:noeticfrom Aug 7, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve Dependency Issue by Prioritizing the Compilation of 'unitree_legged_msgs' Package
Description
Overview:
This pull request addresses a dependency issue encountered while compiling the 'z1_ros' package. Specifically, the 'z1_controller' package relies on the 'unitree_legged_msgs' package, which is currently an uncompiled dependency. To resolve this issue, I propose prioritizing the compilation of the 'unitree_legged_msgs' package to ensure smooth compilation of the 'z1_ros' package.
Background:
The 'z1_ros' package comprises several independent packages with complex interdependencies. As a result, when attempting to compile 'z1_ros', the uncompiled 'unitree_legged_msgs' package causes a build failure due to missing dependencies.
Proposed Solution:
To mitigate the dependency issue, I suggest compiling the 'unitree_legged_msgs' package first before attempting to build the 'z1_ros' package. By doing so, I ensure that all necessary dependencies are satisfied, and 'z1_controller' can access the required messages and services from 'unitree_legged_msgs'.
Steps to Resolve:
Compile 'unitree_legged_msgs' package:
catkin_make --pkg unitree_legged_msgsto compile the package.Compile 'z1_ros' package:
catkin_make --pkg z1_rosto build 'z1_ros' along with its dependencies.Environment:
Ubuntu20.04 VMWARE
ROS1 Noetic
Testing:
To verify the successful resolution of the dependency issue, I have tested the proposed solution on a ROS environment with dependencies identical to 'z1_ros'. The build process now completes without errors, confirming that 'unitree_legged_msgs' is successfully compiled and utilized as a dependency.
Additional Notes:
If accepted, this pull request will ensure a smoother compilation process for the 'z1_ros' package, avoiding potential dependency conflicts and enabling users to utilize the 'z1_controller' package seamlessly.
Thank you for considering this pull request.