Skip to content

feat: support for variable only deployments#430

Merged
CGoodwin90 merged 6 commits intomainfrom
collector-vars-only
Dec 9, 2025
Merged

feat: support for variable only deployments#430
CGoodwin90 merged 6 commits intomainfrom
collector-vars-only

Conversation

@shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Apr 10, 2025

This change allows for a variable to be set when triggering a deployment that will run a variables only deployment.

This will only update the secret where the variables are stored, and restart pods. This means only variables that are RUNTIME or GLOBAL scope will be modified.

If a GLOBAL scope variable has a legitimate build requirement, then this will go unchanged. If you have a GLOBAL scope variable that when changed requires a build step, you should perform a full deployment. If you're only using the GLOBAL scope because you're unsure if a variable is used in a build, chances are it isn't, consider changing to RUNTIME

This will return an error if the user tries to apply variables only changes on an environment that still has a configmap for the variables, a full deployment is required to ensure everything gets updated correctly before running a variables only deployment.

We may need to consider other things to check, for example if some things have changed in the upstream git repo that may result in odd behaviour when the generator runs.

@shreddedbacon shreddedbacon force-pushed the collector-vars-only branch 2 times, most recently from 628896d to 5190008 Compare April 10, 2025 23:55
@shreddedbacon shreddedbacon added this to the 2.25.0 milestone Apr 14, 2025
@shreddedbacon shreddedbacon force-pushed the collector-vars-only branch from 5190008 to 0df2464 Compare May 1, 2025 05:36
Base automatically changed from k8s-collector to main May 6, 2025 17:24
@shreddedbacon shreddedbacon force-pushed the collector-vars-only branch from 0df2464 to d508769 Compare May 7, 2025 01:21
@shreddedbacon shreddedbacon removed this from the 2.25.0 milestone May 19, 2025
@shreddedbacon shreddedbacon force-pushed the collector-vars-only branch 3 times, most recently from 093ed30 to a13793d Compare May 22, 2025 23:21
@shreddedbacon shreddedbacon force-pushed the collector-vars-only branch 2 times, most recently from 60dde26 to 62c10c2 Compare July 28, 2025 05:11
@shreddedbacon shreddedbacon force-pushed the collector-vars-only branch 2 times, most recently from cb21661 to 427cef2 Compare September 3, 2025 06:50
@shreddedbacon shreddedbacon marked this pull request as ready for review December 1, 2025 23:41
@bomoko bomoko self-requested a review December 7, 2025 21:40
Copy link
Contributor

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have run multiple tests of this and it seems to work as expected

@CGoodwin90 CGoodwin90 merged commit 3b77e18 into main Dec 9, 2025
2 checks passed
@CGoodwin90 CGoodwin90 deleted the collector-vars-only branch December 9, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants