feat: support for variable only deployments#430
Merged
CGoodwin90 merged 6 commits intomainfrom Dec 9, 2025
Merged
Conversation
628896d to
5190008
Compare
88fb753 to
8aabaf5
Compare
5190008 to
0df2464
Compare
198878c to
5cbbb1a
Compare
0df2464 to
d508769
Compare
093ed30 to
a13793d
Compare
a13793d to
467c66b
Compare
60dde26 to
62c10c2
Compare
62c10c2 to
6b7d289
Compare
cb21661 to
427cef2
Compare
427cef2 to
030d327
Compare
030d327 to
5a8198c
Compare
4 tasks
5a8198c to
b821c18
Compare
5761bdd to
3054e2f
Compare
bomoko
approved these changes
Dec 9, 2025
Contributor
bomoko
left a comment
There was a problem hiding this comment.
Have run multiple tests of this and it seems to work as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows for a variable to be set when triggering a deployment that will run a variables only deployment.
This will only update the secret where the variables are stored, and restart pods. This means only variables that are
RUNTIMEorGLOBALscope will be modified.If a
GLOBALscope variable has a legitimate build requirement, then this will go unchanged. If you have aGLOBALscope variable that when changed requires a build step, you should perform a full deployment. If you're only using theGLOBALscope because you're unsure if a variable is used in a build, chances are it isn't, consider changing toRUNTIMEThis will return an error if the user tries to apply variables only changes on an environment that still has a configmap for the variables, a full deployment is required to ensure everything gets updated correctly before running a variables only deployment.
We may need to consider other things to check, for example if some things have changed in the upstream git repo that may result in odd behaviour when the generator runs.