fix: commit pending proposals recovery strategy - WPB-23159

WireDomain/Sources/WireDomain/Components/ClientSessionComponent.swift

@@ -772,6 +772,19 @@
         )
     }
 
+    public func createInitiateResetMLSConversationUseCase() -> some InitiateResetMLSConversationUseCaseProtocol {
+        InitiateResetMLSConversationUseCase(
+            api: mlsAPI,
+            mlsService: mlsService,
+            conversationLocalStore: conversationLocalStore,
+            conversationRepository: conversationRepository,
+            lockRepository: ResetMLSConversationLockRepository(
+                userID: selfUserID
+            ),
+            selfDomain: backendMetadata.domain
+        )
+    }
+
     // MARK: - Other
 
     public private(set) lazy var conversationProtobufMessageProcessor = ConversationProtobufMessageProcessor(
@@ -821,7 +834,7 @@
     )
 
     public lazy var workAgent: WorkAgent = .init(scheduler: PriorityOrderWorkItemScheduler())
 
     public lazy var conversationUpdatesGenerator: IncrementalGeneratorProtocol = ConversationUpdatesGenerator(
         repository: conversationRepository,
         context: syncContext,
@@ -830,7 +843,7 @@
             self?.workAgent.submitItem(workItem)
         }
     )
 
     public lazy var commitPendingProposalsGenerator: LiveGeneratorProtocol = CommitPendingProposalsGenerator(
         repository: conversationRepository,
         mlsService: mlsService,

WireDomain/Sources/WireDomain/Repositories/Conversations/LocalStore/ConversationLocalStore.swift

@@ -57,7 +57,7 @@
     // MARK: - Public
 
     public func qualifiedID(for conversation: ZMConversation) async -> QualifiedID? {
         await context.perform {
             conversation.qualifiedID
         }
     }
@@ -66,7 +66,7 @@
         _ lastReadMessage: LastRead,
         in conversation: ZMConversation
     ) async {
         await context.perform { [context] in
             guard conversation.isSelfConversation else {
                 return
             }
@@ -82,7 +82,7 @@
         _ clearedMessage: Cleared,
         in conversation: ZMConversation
     ) async {
         await context.perform { [context] in
             guard conversation.isSelfConversation else {
                 return
             }
@@ -112,10 +112,11 @@
         epoch: UInt64,
         conversation: ZMConversation
     ) async {
         await context.perform {
             conversation.mlsStatus = .ready
             conversation.epoch = epoch
             conversation.mlsGroupID = mlsGroupID
+            conversation.commitPendingProposalDate = nil
         }
     }
 
@@ -123,9 +124,10 @@
         newMLSGroupID: MLSGroupID,
         conversation: ZMConversation
     ) async {
         await context.perform {
             conversation.mlsStatus = .pendingJoinAfterReset
             conversation.mlsGroupID = newMLSGroupID
+            conversation.commitPendingProposalDate = nil
             conversation.epoch = 0
         }
     }
@@ -147,7 +149,7 @@
     public func fetchOtherUserIDInOneOnOneConversation(
         conversation: ZMConversation
     ) async -> WireDataModel.QualifiedID? {
         await context.perform {
             guard conversation.conversationType == .oneOnOne else {
                 WireLogger.conversation.info(
                     "conversation type is not expected 'oneOnOne', aborting."
@@ -158,7 +160,7 @@
 
             guard
                 let otherUser = conversation.localParticipantsExcludingSelf.first,
                 let otherUserID = otherUser.remoteIdentifier,
                 let otherUserDomain = otherUser.domain ?? self.localDomain
             else {
                 WireLogger.conversation.warn(
@@ -184,7 +186,7 @@
             let mutedStatus = mutedStatusInfo.status
             let mutedReference = mutedStatusInfo.referenceDate
 
             if let mutedStatus, let mutedReference {
                 localConversation.updateMutedStatus(
                     status: Int32(mutedStatus),
                     referenceDate: mutedReference
@@ -248,9 +250,9 @@
 
         await context.perform {
             // If user is already part of the conversation, its role will be updated.
             // If not, user will be added to the conversation.
             conversation.addParticipantAndUpdateConversationState(
                 user: user,
                 role: role
             )
         }
@@ -259,7 +261,7 @@
     public func increaseUnreadCount(
         for conversation: ZMConversation
     ) async {
         await context.perform {
             conversation.internalEstimatedUnreadCount += 1
         }
     }
@@ -267,7 +269,7 @@
     public func decreaseUnreadCount(
         for conversation: ZMConversation
     ) async {
         await context.perform {
             conversation.internalEstimatedUnreadCount -= 1
         }
     }
@@ -275,7 +277,7 @@
     public func increaseUnreadSelfMentionCount(
         for conversation: ZMConversation
     ) async {
         await context.perform {
             conversation.internalEstimatedUnreadSelfMentionCount += 1
         }
     }
@@ -283,7 +285,7 @@
     public func increaseUnreadSelfReplyCount(
         for conversation: ZMConversation
     ) async {
         await context.perform {
             conversation.internalEstimatedUnreadSelfReplyCount += 1
         }
     }
@@ -298,7 +300,7 @@
         permission: Conversation.ChannelPermission,
         conversation: ZMConversation
     ) async {
         await context.perform {
             conversation.privateChannelPermission = PrivateChannelPermission(permission)
         }
     }
@@ -313,7 +315,7 @@
             domain: conversationDomain
         )
 
         await context.perform {
             conversation?.channelHistoryDepth = historyDepth
         }
     }
@@ -345,9 +347,9 @@
                 ]
             )
         }
 
         let usersAndRoles = await withTaskGroup(of: UserAndRole?.self) { taskGroup in
             for newParticipant in participants {
                 taskGroup.addTask { [self] in
                     let user = await context.perform { [context] in
                         ZMUser.fetchOrCreate(
@@ -371,7 +373,7 @@
             }
 
             var usersAndRoles: [UserAndRole?] = []
 
             for await userAndRole in taskGroup {
                 usersAndRoles.append(userAndRole)
             }
@@ -400,8 +402,8 @@
             )
         }
 
         await context.perform {
             localConversation.addParticipantsAndUpdateConversationState(
                 usersAndRoles: usersAndRoles
             )
         }
@@ -411,7 +413,7 @@
         user: ZMUser,
         conversation: ZMConversation
     ) async {
         await context.perform { [context] in
             if user.objectID.isTemporaryID || conversation.objectID.isTemporaryID {
                 do {
                     try context.obtainPermanentIDs(for: [user, conversation])
@@ -429,7 +431,7 @@
         to conversation: ZMConversation
     ) async {
         await context.perform { [context] in
             let systemMessage = ZMSystemMessage(nonce: UUID(), managedObjectContext: context)
             systemMessage.systemMessageType = message.type
             systemMessage.sender = message.sender
             systemMessage.users = message.users ?? Set()
@@ -448,7 +450,7 @@
             systemMessage.relevantForConversationStatus = message.relevantForStatus
             systemMessage.participantsRemovedReason = message.removedReason
             systemMessage.domains = message.domains
 
             conversation.append(systemMessage)
         }
     }
@@ -546,7 +548,7 @@
             domain: conversationDomain
         )
 
         await context.perform {
             conversation.isPendingMetadataRefresh = true
             conversation.needsToBeUpdatedFromBackend = true
         }
@@ -587,7 +589,7 @@
     public func conversationNeedsBackendUpdate(
         _ conversation: ZMConversation
     ) async -> Bool {
         await context.perform {
             conversation.needsToBeUpdatedFromBackend
         }
     }
@@ -595,7 +597,7 @@
     public func isConversationArchived(
         _ conversation: ZMConversation
     ) async -> Bool {
         await context.perform {
             conversation.isArchived
         }
     }
@@ -603,7 +605,7 @@
     public func isConversationForcedReadOnly(
         _ conversation: ZMConversation
     ) async -> Bool {
         await context.perform {
             conversation.isForcedReadOnly
         }
     }
@@ -613,7 +615,7 @@
         senderID: UUID?,
         conversation: ZMConversation
     ) async -> Bool {
         await context.perform {
             conversation.isMessageSilenced(message, senderID: senderID)
         }
     }
@@ -636,7 +638,7 @@
     ) async {
         let scheduledDate = date + TimeInterval(commitDelay)
 
         await context.perform {
             conversation.commitPendingProposalDate = scheduledDate
         }
     }
@@ -647,7 +649,7 @@
         date: Date
     ) async {
         // Update the legal hold state in the conversation
         await context.perform {
             conversation.updateSecurityLevelIfNeededAfterReceiving(
                 message: genericMessage,
                 timestamp: date
@@ -672,8 +674,8 @@
             return
         }
 
         await context.perform {
             conversation.addParticipantAndSystemMessageIfMissing(
                 participant,
                 date: date
             )
@@ -683,7 +685,7 @@
     public func conversationMutedMessageTypes(
         _ conversation: ZMConversation
     ) async -> MutedMessageTypes {
         await context.perform {
             conversation.mutedMessageTypes
         }
     }
@@ -692,7 +694,7 @@
         _ conversation: ZMConversation
     ) async -> MutedMessageTypes {
         await context.perform { [context] in
             let selfUser = ZMUser.selfUser(in: context)
             return selfUser.mutedMessagesTypes.union(conversation.mutedMessageTypes)
         }
     }
@@ -700,7 +702,7 @@
     public func lastReadServerTimestamp(
         _ conversation: ZMConversation
     ) async -> Date? {
         await context.perform {
             conversation.lastReadServerTimeStamp
         }
     }
@@ -708,7 +710,7 @@
     public func conversationMessageDestructionTimeout(
         _ conversation: ZMConversation
     ) async -> MessageDestructionTimeoutValue {
         await context.perform {
             conversation.activeMessageDestructionTimeoutValue ?? .init(rawValue: 0)
         }
     }
@@ -717,7 +719,7 @@
         timeoutValue: Double,
         for conversation: ZMConversation
     ) async {
         await context.perform {
             conversation.setMessageDestructionTimeoutValue(
                 .init(rawValue: timeoutValue),
                 for: .groupConversation
@@ -729,7 +731,7 @@
         hasReadReceiptsEnabled: Bool,
         for conversation: ZMConversation
     ) async {
         await context.perform {
             conversation.hasReadReceiptsEnabled = hasReadReceiptsEnabled
         }
     }
@@ -737,7 +739,7 @@
     public func messageProtocol(
         for conversation: ZMConversation
     ) async -> WireDataModel.MessageProtocol {
         await context.perform {
             conversation.messageProtocol
         }
     }
@@ -745,13 +747,13 @@
     public func isGroupConversation(
         _ conversation: ZMConversation
     ) async -> Bool {
         await context.perform {
             conversation.conversationType == .group
         }
     }
 
     public func isSelfConversation(_ conversation: ZMConversation) async -> Bool {
         await context.perform {
             conversation.conversationType == .self
         }
     }
@@ -759,7 +761,7 @@
     public func name(
         for conversation: ZMConversation
     ) async -> String? {
         await context.perform {
             conversation.displayName
         }
     }
@@ -779,7 +781,7 @@
         }
 
         let allGroupConversations = await context.perform {
             // swiftformat:disable:next redundantProperty
             let allGroupConversations: [ZMConversation] = user.participantRoles.compactMap {
                 guard $0.conversation?.conversationType == .group else {
                     return nil
@@ -793,9 +795,9 @@
 
         for conversation in allGroupConversations {
             let (userTeam, isTeamMember, conversationTeam, conversationID, conversationDomain) = await context.perform {
                 (
                     user.team,
                     user.isTeamMember,
                     conversation.team,
                     conversation.remoteIdentifier as UUID,
                     conversation.domain
@@ -830,8 +832,8 @@
                 )
             }
 
             await context.perform {
                 conversation.removeParticipantAndUpdateConversationState(
                     user: user,
                     initiatingUser: user
                 )
@@ -845,7 +847,7 @@
     ) async -> Role {
         await context.perform { [context] in
             Role.fetchOrCreateRole(
                 with: role,
                 teamOrConversation: TeamOrConversation.matching(conversation),
                 in: context
             )
@@ -857,7 +859,7 @@
         accessModes: [String],
         accessRoles: [String]
     ) async {
         await context.perform { [context] in
             conversation.accessModeStrings = accessModes
             conversation.accessRoleStringsV2 = accessRoles
 
@@ -880,7 +882,7 @@
         isDeletedRemotely: Bool,
         conversation: ZMConversation
     ) async {
         await context.perform {
             conversation.isDeletedRemotely = isDeletedRemotely
         }
     }
@@ -890,9 +892,9 @@
         users: Set<ZMUser>,
         initiatingUser: ZMUser
     ) async {
         await context.perform {
             conversation.removeParticipantsAndUpdateConversationState(
                 users: users,
                 initiatingUser: initiatingUser
             )
         }
@@ -901,7 +903,7 @@
     public func localParticipants(
         in conversation: ZMConversation
     ) async -> Set<ZMUser> {
         await context.perform {
             conversation.localParticipants
         }
     }
@@ -909,7 +911,7 @@
     public func conversationName(
         conversation: ZMConversation
     ) async -> String? {
         await context.perform {
             conversation.userDefinedName
         }
     }
@@ -918,7 +920,7 @@
         newName: String,
         conversation: ZMConversation
     ) async {
         await context.perform {
             conversation.userDefinedName = newName
         }
     }
@@ -958,10 +960,10 @@
             domain: conversation.qualifiedID?.domain
         )
 
         await context.perform { [self] in
             localConversation.conversationType = .connection
 
             commonUpdate(
                 from: conversation,
                 for: localConversation,
                 serverTimestamp: serverTimestamp,
@@ -1015,15 +1017,15 @@
             domain: conversation.qualifiedID?.domain
         )
 
         let mlsGroupID = await context.perform {
             conversation.mlsGroupID
         }
 
         await context.perform { [self] in
             localConversation.conversationType = .`self`
             localConversation.isPendingMetadataRefresh = false
 
             commonUpdate(
                 from: conversation,
                 for: localConversation,
                 serverTimestamp: serverTimestamp,
@@ -1072,13 +1074,13 @@
             domain: conversation.qualifiedID?.domain
         )
 
         await context.perform { [self] in
             isInitialFetch = localConversation.isPendingInitialFetch
 
             localConversation.conversationType = .group
             localConversation.remoteIdentifier = id
             localConversation.isPendingMetadataRefresh = false
             localConversation.isPendingInitialFetch = false
             localConversation.groupType = conversation.groupType.map { groupType in
                 switch groupType {
                 case .group:
@@ -1101,7 +1103,7 @@
                     .disabled
                 }
             } ?? .disabled
 
             commonUpdate(
                 from: conversation,
                 for: localConversation,
@@ -1114,7 +1116,7 @@
                 from: conversation,
                 for: localConversation
             )
 
             if isInitialFetch {
                 assignMessageProtocol(
                     from: conversation,
@@ -1149,9 +1151,9 @@
             isMLSEnabled: isMLSEnabled
         )
 
         await context.perform { [self] in
             if isInitialFetch {
                 // we just got a new conversation, we display new conversation header
                 localConversation.appendNewConversationSystemMessage(
                     at: .distantPast,
                     users: localConversation.localParticipants
@@ -1166,7 +1168,7 @@
             }
 
             // If we discover this group is actually a fake one on one,
             // then we should link the one on one user.
             linkOneOnOneUserIfNeeded(for: localConversation)
 
             // All metadata has been updated, object does not need to be updated from backend
@@ -1201,14 +1203,14 @@
             let conversationType = BackendConversationType.clientConversationType(
                 rawValue: conversationTypeRawValue
             )
 
             if localConversation.oneOnOneUser?.connection?.status == .sent {
                 localConversation.conversationType = .connection
             } else {
                 localConversation.conversationType = conversationType
             }
 
             assignMessageProtocol(
                 from: conversation,
                 for: localConversation
             )
@@ -1309,7 +1311,7 @@
             domain: conversationDomain
         )
 
         return await context.perform {
             handler(conversation)
         }
     }

WireDomain/Sources/WireDomain/Repositories/Conversations/Protocols/ConversationRepositoryProtocol.swift

@@ -198,4 +198,9 @@ public protocol ConversationRepositoryProtocol: Sendable {
     func isSelfAnActiveMember(
         in groupID: WireDataModel.MLSGroupID
     ) async -> Bool
+
+    /// Reset the pendingProposalDate for the conversation
+    /// - Parameter groupID: mlsGroupID of the conversation
+    func clearPendingProposals(in groupID: WireDataModel.MLSGroupID) async
+
 }

WireDomain/Sources/WireDomain/Repositories/Conversations/Repository/ConversationRepository.swift

@@ -18,21 +18,21 @@
 
 import Foundation
 import WireDataModel
 import WireLogging
 import WireNetwork
 
 public final class ConversationRepository: ConversationRepositoryProtocol {
 
     // MARK: - Properties
 
     private let conversationsAPI: any ConversationsAPI
     private let conversationsLocalStore: any ConversationLocalStoreProtocol
     private let userLocalStore: any UserLocalStoreProtocol
     private let teamRepository: any TeamRepositoryProtocol
     private let messageRepository: any MessageRepositoryProtocol
     private let localDomain: String
     private let isFederationEnabled: Bool
     private let isMLSEnabled: Bool
     private let mlsProvider: MLSProvider
 
     // MARK: - Object lifecycle
@@ -390,6 +390,13 @@
         return isSelfAnActiveMember
     }
 
+    public func clearPendingProposals(in groupID: WireDataModel.MLSGroupID) async {
+        await conversationsLocalStore.execute(identifier: groupID) { conversation, context in
+            conversation?.commitPendingProposalDate = nil
+            context.saveOrRollback()
+        }
+    }
+
     // MARK: - Private
 
     private func addSystemMessage(
@@ -424,9 +431,9 @@
 
     private func getRemovedUsers(
         from userIDs: Set<UserID>
     ) async -> [WireDataModel.ZMUser] {
         await withTaskGroup(of: WireDataModel.ZMUser.self) { taskGroup in
             for userID in userIDs {
                 taskGroup.addTask { [self] in
                     await userLocalStore.fetchOrCreateUser(
                         id: userID.id,
@@ -436,7 +443,7 @@
             }
 
             var users: [WireDataModel.ZMUser] = []
 
             for await user in taskGroup {
                 users.append(user)
             }

WireDomain/Sources/WireDomain/WorkAgent/WorkAgent.swift

@@ -136,6 +136,9 @@ public actor WorkAgent {
         task = nil
     }
 
+    public func clearSchedulerQueue() async {
+        await scheduler.clearAllItems()
+    }
 }
 
 extension LogAttributes {

WireDomain/Sources/WireDomain/WorkAgent/WorkItem/CommitPendingProposalItem.swift

@@ -25,11 +25,16 @@ struct CommitPendingProposalItem: WorkItem, CustomStringConvertible {
     private let repository: ConversationRepositoryProtocol
     private let mlsService: MLSServiceInterface
 
+    let _internalID = UUID()
+
+    var id: String {
+        "commitPendingProposalItem_\(_internalID)_\(groupID)_\(conversationID)"
+    }
+
     var description: String {
-        "CommitPendingProposalItem: \(id), mlsGroupID: \(groupID), conversationID: \(conversationID)"
+        "CommitPendingProposalItem: \(_internalID), mlsGroupID: \(groupID), conversationID: \(conversationID)"
     }
 
-    let id = UUID()
     var priority: WorkItemPriority {
         .medium
     }
@@ -60,6 +65,12 @@ struct CommitPendingProposalItem: WorkItem, CustomStringConvertible {
             return
         }
 
+        guard try await mlsService.conversationExists(groupID: groupID) else {
+            logger.warn("mls group does not exist, clearing pending proposal", attributes: logAttributes)
+            await repository.clearPendingProposals(in: groupID)
+            return
+        }
+
         logger.info("committing pending proposals now...", attributes: logAttributes)
         try await mlsService.commitPendingProposals(in: groupID)
     }

WireDomain/Sources/WireDomain/WorkAgent/WorkItem/RepairFaultyMLSRemovalKeysWorkItem.swift

@@ -27,12 +27,15 @@
 
 struct RepairFaultyMLSRemovalKeysWorkItem: WorkItem {
 
-    let id = UUID()
+    var id: String {
+        "repairFaultyMLSRemovalKeys_\(UUID().uuidString)"
+    }
+
     var priority: WorkItemPriority {
         .low
     }
 
     private let journal: any JournalProtocol
     private let repairUseCase: any RepairRemovalKeysUseCaseProtocol
 
     init(

WireDomain/Sources/WireDomain/WorkAgent/WorkItem/UpdateConversationItem.swift

@@ -24,7 +24,16 @@ import WireNetwork
 struct UpdateConversationItem: WorkItem {
     private let repository: ConversationRepositoryProtocol
 
-    let id = UUID()
+    let _internalID = UUID()
+
+    var id: String {
+        "updateConversationItem_\(_internalID.uuidString)_\(conversationID)"
+    }
+
+    var description: String {
+        "UpdateConversationItem: \(_internalID.uuidString), conversationID: \(conversationID)"
+    }
+
     var priority: WorkItemPriority {
         .medium
     }

WireDomain/Sources/WireDomain/WorkAgent/WorkItem/WorkItem.swift

@@ -27,7 +27,7 @@ protocol WorkItem: Sendable {
 
     /// A unique identifier for this item.
 
-    var id: UUID { get }
+    var id: String { get }
 
     /// The urgency or importance of this ticket.
 

WireDomain/Sources/WireDomain/WorkAgent/WorkItemScheduler/PriorityOrderWorkItemScheduler.swift

@@ -54,4 +54,10 @@ actor PriorityOrderWorkItemScheduler: WorkItemScheduler {
         }
     }
 
+    func clearAllItems() async {
+        blockerQueue.removeAll()
+        highQueue.removeAll()
+        mediumQueue.removeAll()
+        lowQueue.removeAll()
+    }
 }

WireDomain/Sources/WireDomain/WorkAgent/WorkItemScheduler/WorkItemScheduler.swift

@@ -38,4 +38,8 @@ protocol WorkItemScheduler: Sendable {
     /// - Returns: The next available item.
 
     func dequeueNextItem() async -> (any WorkItem)?
+
+    /// Clears all items from queues
+
+    func clearAllItems() async
 }

WireDomain/Tests/WireDomainTests/WorkAgent/PriorityOrderWorkSchedulerTests.swift

@@ -121,7 +121,7 @@ struct PriorityOrderWorkItemSchedulerTests {
 
 private struct MockWorkItem: WorkItem, Equatable {
 
-    let id = UUID()
+    let id = UUID().uuidString
     let priority: WorkItemPriority
     func start() async throws {}
 

WireDomain/Tests/WireDomainTests/WorkAgent/WorkAgentTests.swift

@@ -88,11 +88,28 @@ struct WorkAgentTests {
         #expect(await item.startCalls == 1)
     }
 
+    @Test("Clear items are removed")
+    func clearItems() async throws {
+        // Given
+        let item = MockWorkItem(priority: .medium)
+        await sut.submitItem(item)
+        await Task.yield()
+
+        #expect(await scheduler.enqueuedItems.count == 1)
+
+        // When
+        await sut.clearSchedulerQueue()
+
+        // Then
+        #expect(await scheduler.items.isEmpty)
+        #expect(await scheduler.enqueuedItems.isEmpty)
+    }
+
 }
 
 private actor MockWorkItem: WorkItem {
 
-    let id = UUID()
+    let id = UUID().uuidString
     let priority: WorkItemPriority
 
     var startCalls = 0
@@ -137,4 +154,8 @@ private actor MockScheduler: WorkItemScheduler {
         return item
     }
 
+    func clearAllItems() async {
+        enqueuedItems.removeAll()
+        items.removeAll()
+    }
 }

WireDomain/Tests/WireDomainTests/WorkAgent/WorkItem/CommitPendingProposalItemTests.swift

@@ -39,6 +39,7 @@ class CommitPendingProposalItemTests {
         self.mlsGroupID = .random()
         self.mlsService = .init()
         mlsService.commitPendingProposalsIn_MockMethod = { _ in }
+        mlsService.conversationExistsGroupID_MockValue = true
         repository.isSelfAnActiveMemberIn_MockValue = true
     }
 
@@ -76,6 +77,22 @@ class CommitPendingProposalItemTests {
         #expect(mlsService.commitPendingProposalsIn_Invocations.isEmpty)
     }
 
+    @Test("It does not call commitPendingProposal when mlsGroup does not exist")
+    func startDoesNotCommitWhenMLSGroupDoesNotExist() async throws {
+        // Given
+        repository.clearPendingProposalsIn_MockMethod = { _ in }
+        mlsService.conversationExistsGroupID_MockValue = false
+
+        sut = makeProposalItem()
+
+        // When
+        try await sut.start()
+
+        // Then
+        #expect(mlsService.commitPendingProposalsIn_Invocations.isEmpty)
+        #expect(repository.clearPendingProposalsIn_Invocations.count == 1)
+    }
+
     @Test("It logs properly")
     func loggingDescription() {
         // Given

WireFoundation/Sources/WireFoundation/Utilities/BackoffRetry/BackoffRetrier.swift

@@ -25,7 +25,7 @@ public actor BackoffRetrier {
         _ seconds: Double
     ) async throws -> Void
 
-    enum Failure: Error {
+    public enum Failure: Error {
         case exceededMaxAttempts(latestError: any Error)
     }
 
@@ -36,14 +36,16 @@ public actor BackoffRetrier {
 
     public init(
         policy: BackoffRetryPolicy = .init(),
+        monitoringNetwork: Bool = true,
         sleep: @escaping SleepFunction = { delay in
             try await Task.sleep(nanoseconds: UInt64(delay * 1_000_000_000))
         }
     ) {
         self.policy = policy
         self.sleep = sleep
-
-        setupObservers()
+        if monitoringNetwork {
+            setupObservers()
+        }
     }
 
     deinit {