fix FastSAC evaluate_policy missing set_is_evaluating call#53
Merged
samuelgundry merged 1 commit intoamazon-far:mainfrom Feb 19, 2026
Merged
fix FastSAC evaluate_policy missing set_is_evaluating call#53samuelgundry merged 1 commit intoamazon-far:mainfrom
samuelgundry merged 1 commit intoamazon-far:mainfrom
Conversation
Juyue
approved these changes
Feb 19, 2026
Contributor
Juyue
left a comment
Juyue
left a comment
There was a problem hiding this comment.
lgtm! Thank you for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
FastSAC's
evaluate_policy()was missing aset_is_evaluating()call, unlike PPO which has it in_pre_evaluate_policy(). Without this the environment during evaluation:This makes the robot appear to receive random actions and get pushed around during eval, rather than standing still awaiting keyboard/joystick input.
--
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.