Skip to content

Miscellaneous changes & fixes#56

Merged
samuelgundry merged 2 commits intomainfrom
dev/jchen/misc_20260218-3
Feb 19, 2026
Merged

Miscellaneous changes & fixes#56
samuelgundry merged 2 commits intomainfrom
dev/jchen/misc_20260218-3

Conversation

@Juyue
Copy link
Contributor

@Juyue Juyue commented Feb 18, 2026

Miscellaneous changes/fixes

  1. Fix evaluate_policy in fast_sac_agent. Now self.env.is_evaluating will be properly set when running eval_agent.py

  2. Fix LocomotionCommand.reset. Now, user can use cmd line to set the ranges of velocity they want to eval. For example:

    --command.setup_terms.locomotion_command.params.command_ranges.lin_vel_x="[0.5, 0.5]" --command.setup_terms.locomotion_command.params.command_ranges.lin_vel_y="[0.0, 0.0]" --command.setup_terms.locomotion_command.params.command_ranges.ang_vel_yaw="[0.0, 0.0]"
    
  3. Make default_robot configurable in retargeting for other robots. This has no functional changes to existing g1/t1.

    Tested with

    python examples/robot_retarget.py --data_path demo_data/OMOMO_new --task-type robot_only --task-name sub3_largebox_003 --data_format smplh --retargeter.debug --retargeter.visualize
    
    python data_conversion/convert_data_format_mj.py --input_file ./demo_results/g1/robot_only/omomo/sub3_largebox_003.npz --output_fps 50 --output_name converted_res/robot_only/sub3_largebox_003_mj_fps50.npz --data_format smplh --object_name "ground" --once
    
  4. Adjust isaacsim viewer viewing angles when tracking is enabled.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Juyue Juyue changed the title [Misc] Miscellaneous changes & fixes Feb 19, 2026
@carlosferrazza
Copy link
Contributor

carlosferrazza commented Feb 19, 2026

lgtm!

@maedmatt
Copy link
Contributor

#53 was solving one of those issues : (

Copy link
Contributor

@lijiaman lijiaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Juyue
Copy link
Contributor Author

Juyue commented Feb 19, 2026

#53 was solving one of those issues : (

Thanks! Have approved and merged #53 !

@clayrosenthal clayrosenthal added the bug Something isn't working label Feb 19, 2026
Juyue Chen added 2 commits February 19, 2026 13:32
@Juyue Juyue force-pushed the dev/jchen/misc_20260218-3 branch from cb007a9 to a33ed61 Compare February 19, 2026 21:32
@samuelgundry samuelgundry merged commit 0da042c into main Feb 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants