Skip to content
This repository was archived by the owner on Nov 24, 2021. It is now read-only.

fix using nodemailer send email fail#19

Open
miaowing wants to merge 3 commits intokeystonejs:masterfrom
miaowing:master
Open

fix using nodemailer send email fail#19
miaowing wants to merge 3 commits intokeystonejs:masterfrom
miaowing:master

Conversation

@miaowing
Copy link

{ Error: Invalid sender "admin xxx@xxx.com"
at SMTPConnection._formatError (/Users/feng/workspace/web/yr/node_modules/smtp-connection/lib/smtp-connection.js:528:15)
at SMTPConnection._setEnvelope (/Users/feng/workspace/web/yr/node_modules/smtp-connection/lib/smtp-connection.js:723:30)
at SMTPConnection.send (/Users/feng/workspace/web/yr/node_modules/smtp-connection/lib/smtp-connection.js:383:10)
at SMTPTransport. (/Users/feng/workspace/web/yr/node_modules/nodemailer-smtp-transport/lib/smtp-transport.js:126:24)
at /Users/feng/workspace/web/yr/node_modules/nodemailer-smtp-transport/lib/smtp-transport.js:162:21
at SMTPConnection._actionAUTHComplete (/Users/feng/workspace/web/yr/node_modules/smtp-connection/lib/smtp-connection.js:1236:5)
at SMTPConnection. (/Users/feng/workspace/web/yr/node_modules/smtp-connection/lib/smtp-connection.js:319:22)
at SMTPConnection._processResponse (/Users/feng/workspace/web/yr/node_modules/smtp-connection/lib/smtp-connection.js:669:16)
at SMTPConnection._onData (/Users/feng/workspace/web/yr/node_modules/smtp-connection/lib/smtp-connection.js:493:10)
at emitOne (events.js:96:13)
at TLSSocket.emit (events.js:188:7)
at readableAddChunk (_stream_readable.js:176:18)
at TLSSocket.Readable.push (_stream_readable.js:134:10)
at TLSWrap.onread (net.js:551:20) code: 'EENVELOPE', command: 'API' }

see https://nodemailer.com/address-formatting/

@LorbusChris
Copy link
Contributor

Great 👍
Do you mind moving processAdress.js from utiils back to mailgun? When I implemented nodemailer I reused it and moved it to the shared utils folder. It's probably better to un-do that now. And I think it'd be highly appreciated if the hierarchy in tests/index.js were updated to reflect the latest changes. To test nodemailer/processAdress.js you can probably re-use most of the ex-utils mailgun/processAdress.js tests.

Almost forgot, there is a test-send command, as well. Could you make sure it ran successfully?

Thanks

@miaowing
Copy link
Author

I have ever add some test cases and send email success.

Thanks your suggestion👍.

@hellogerard
Copy link

hellogerard commented Jan 27, 2017

This fixed two issues for me: the import path issues, and the inability to specify a sender name. 👍 :shipit:

@quaz579
Copy link

quaz579 commented Oct 24, 2017

Is there any information around when this might be merged into keystonejs-master? We'd love to use this functionality on our project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants